Eip86 CREATE #4046

yann300 · 2017-04-19T12:10:44Z

Set the address of any contract created through a creation transaction to equal sha3(NULL_SENDER + sha3(init code)) % 2**160, where + represents concatenation, replacing the earlier address formula of sha3(rlp.encode([sender, nonce]))
Create a new opcode at 0xfb, CREATE_P2SH, which sets the creation address to sha3(sender + sha3(init code)) % 2**160. If a contract at that address already exists, fails and returns 0 as if the init code had run out of gas.

On Travis CI limit cache to 1 GB and cleanup after the build. Print better CMake logs and stats.

move transaction verification checks to sealEngine

pirapira · 2017-04-19T13:32:20Z

libethereum/Executive.cpp

@@ -391,6 +400,8 @@ bool Executive::go(OnOpFunc const& _onOp)
 			auto vm = _onOp ? VMFactory::create(VMKind::Interpreter) : VMFactory::create();
 			if (m_isCreation)
 			{
+				if (m_s.addressHasCode(m_newAddress))


I think this happens only after Metropolis (although I doubt I can trigger this right now).

I remember there is a test case about this...

That stuff will basically never return true before Metropolis. but yeah that worth testing only after metro

winsvega · 2017-04-19T13:36:00Z

I'will start working on the tests tomorrow.

pirapira · 2017-04-19T13:37:07Z

test/tools/jsontests/vm.cpp

+
+h160 MetropolisFakeExtVM::create(u256 _endowment, u256& io_gas, bytesConstRef _init, OnOpFunc const&, Instruction _creationType)
+{
+	(void)_creationType;


Do you need this line?

if not it will not build (not used parameter are treated as error)

This parameter is used below.

well wait... you're right :) don't need this line

pirapira · 2017-04-19T13:59:45Z

Looks OK except the Travis failure.

gumb0 · 2017-04-19T14:23:52Z

libevm/VM.cpp

+
+		CASE(CREATE_PSH)
+		{
+			m_bounce = &VM::caseCreate;


It should be available only after Metropolis and generate BadInstruction before. See for example how REVERT handles this

remove blockHash tests from stateTests

gumb0 · 2017-04-19T14:29:58Z

Also the changes are needed in libevmcore/Instruction.cpp - add new instuction to c_instructionInfo - it's used to calculate instruction price; and to c_instructions - it's used by vmtrace

See my changes for REVERT https://github.com/ethereum/cpp-ethereum/pull/3635/files#diff-eebc659bb21aa390ba67700a3586fb13

gumb0 · 2017-04-19T14:32:57Z

test/tools/jsontests/vm.h

@@ -80,5 +80,12 @@ class FakeExtVM: public eth::ExtVMFace
 	u256 execGas;
 };

+class MetropolisFakeExtVM: public FakeExtVM


This class looks not used

yep we will try to remove the entire fakeExtVM with @winsvega

gumb0 · 2017-04-19T14:58:53Z

libevm/ExtVMFace.h

@@ -298,7 +298,7 @@ class ExtVMFace
 	virtual void suicide(Address) { sub.suicides.insert(myAddress); }

 	/// Create a new (contract) account.
-	virtual h160 create(u256, u256&, bytesConstRef, OnOpFunc const&) { return h160(); }
+	virtual h160 create(u256, u256&, bytesConstRef, OnOpFunc const&, Instruction) { return h160(); }


I would better make OnOpFunc parameter the last one, because it's kind of different than all the others - all others are configuring the creation and this one is a callback

Improve ccache usage

…eip86_create Conflicts: libethereum/Executive.cpp libevm/VM.cpp libevmcore/Instruction.cpp libevmcore/Instruction.h test/tools/jsontests/vm.cpp

yann300 · 2017-04-21T15:29:10Z

will move to #4051

chfast and others added 3 commits April 14, 2017 18:07

Improve ccache usage

4167f7c

On Travis CI limit cache to 1 GB and cleanup after the build. Print better CMake logs and stats.

change create tx

f2b1b1a

eip86_create

26b2f33

yann300 added the in progress label Apr 19, 2017

yann300 and others added 9 commits April 19, 2017 14:21

thrown if address already used

52422f5

move transaction verification checks to sealEngine

88df551

use BlockHeader in EnvInfo

8201381

fixes

d4b41c0

json tests

e4db842

MetropolisFakeExtVM

d0d8fc3

Merge pull request #4039 from winsvega/develop

c348678

move transaction verification checks to sealEngine

remove blockHash tests from stateTests

de767ca

jsontests

09f8b94

pirapira reviewed Apr 19, 2017

View reviewed changes

yann300 added 2 commits April 19, 2017 15:54

remove (void)var

995dbdb

check already used address only if after metropolis

e95fdbb

gumb0 suggested changes Apr 19, 2017

View reviewed changes

Merge pull request #4047 from winsvega/remhash

231394a

remove blockHash tests from stateTests

gumb0 reviewed Apr 19, 2017

View reviewed changes

properly implement CREATE_PSH

6c30f3c

gumb0 reviewed Apr 19, 2017

View reviewed changes

yann300 added 2 commits April 19, 2017 17:52

remove MetropolisFakeExtVM

ca3f062

fix build (evmjit)

cf0bb90

gumb0 approved these changes Apr 20, 2017

View reviewed changes

chfast and others added 2 commits April 20, 2017 12:57

Merge pull request #4042 from ethereum/ccache

d491c9d

Improve ccache usage

change create tx

98b2371

yann300 added 10 commits April 20, 2017 15:35

eip86_create

9931b85

thrown if address already used

8eeeace

MetropolisFakeExtVM

22bae65

remove (void)var

406e4fd

check already used address only if after metropolis

1fa7213

properly implement CREATE_PSH

ffc5996

remove MetropolisFakeExtVM

4b2f69a

fix build (evmjit)

99768e2

rename CREATE_PSH => CREATE_P2SH

a0b8dbe

Merge branch 'eip86_create' of github.com:ethereum/cpp-ethereum into …

dc795fd

…eip86_create Conflicts: libethereum/Executive.cpp libevm/VM.cpp libevmcore/Instruction.cpp libevmcore/Instruction.h test/tools/jsontests/vm.cpp

chfast added this to the Metropolis milestone Apr 21, 2017

chfast mentioned this pull request Apr 21, 2017

[META] Byzantium implementation progress #4050

Closed

17 tasks

yann300 closed this Apr 21, 2017

yann300 removed the in progress label Apr 21, 2017

axic deleted the eip86_create branch January 12, 2018 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eip86 CREATE #4046

Eip86 CREATE #4046

yann300 commented Apr 19, 2017

pirapira Apr 19, 2017

pirapira Apr 19, 2017

yann300 Apr 19, 2017

winsvega commented Apr 19, 2017

pirapira Apr 19, 2017

yann300 Apr 19, 2017 •

edited

Loading

pirapira Apr 19, 2017

yann300 Apr 19, 2017

pirapira commented Apr 19, 2017

gumb0 Apr 19, 2017

gumb0 commented Apr 19, 2017

gumb0 Apr 19, 2017

yann300 Apr 19, 2017

gumb0 Apr 19, 2017

yann300 commented Apr 21, 2017

Eip86 CREATE #4046

Eip86 CREATE #4046

Conversation

yann300 commented Apr 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

winsvega commented Apr 19, 2017

Choose a reason for hiding this comment

yann300 Apr 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pirapira commented Apr 19, 2017

Choose a reason for hiding this comment

gumb0 commented Apr 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yann300 commented Apr 21, 2017

yann300 Apr 19, 2017 •

edited

Loading